-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loop efficiency w/ cupy #155
base: main
Are you sure you want to change the base?
Conversation
Can possibly use this action in workflow? @zpapakipos @jbitton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great! Since you're adding a new optional dependency, we should document that so users know how to add gpu support when installing augly
. Can you add a note about this in the audio README "Installation" section? For example you could add after what's already in that section, "If you have CUDA in your environment & want to use GPU-acceleration to speed up the audio augmentations, you can install augly
using the following command: pip install augly[av,gpu]
."
Co-authored-by: Zoe Papakipos <[email protected]>
Co-authored-by: Zoe Papakipos <[email protected]>
Co-authored-by: Zoe Papakipos <[email protected]>
Related Issue
Fixes N/A
Summary
<Please summarize what you are trying to achieve, what changes you made, and how they acheive the desired result.>
Added
cupy
as a dependency, rewroteloop
accordingly.Previous runtime: 0.14577968645095826s
New runtime: 0.006239746809005737s
ISSUES
Local machine does not have CUDA installed, so cannot rely on it to pass unit testing or install
cupy
.Unit Tests
If your changes touch the
audio
module, please run all of theaudio
tests and paste the output here. Likewise forimage
,text
, &video
. If your changes could affect behavior in multiple modules, please run the tests for all potentially affected modules. If you are unsure of which modules might be affected by your changes, please just run all the unit tests.Audio
python -m unittest discover -s augly/tests/audio_tests/ -p "*"
Image
Text
python -m unittest discover -s augly/tests/text_tests/ -p "*"
Video
python -m unittest discover -s augly/tests/video_tests/ -p "*"
All
python -m unittest discover -s augly/tests/ -p "*"
Other testing
If applicable, test your changes and paste the output here. For example, if your changes affect the requirements/installation, then test installing augly in a fresh conda env, then make sure you are able to import augly & run the unit test