Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Dependency bumps to fix cleaninstall CI #3588

Merged
merged 11 commits into from
Apr 17, 2021
Merged

Dependency bumps to fix cleaninstall CI #3588

merged 11 commits into from
Apr 17, 2021

Conversation

mojtaba-komeili
Copy link
Contributor

Patch description
Trying to fix some of the recently broken ParlAI tests.

@mojtaba-komeili mojtaba-komeili changed the title emoji order install changed CircleCI cleaninstall_37 fix Apr 14, 2021
@mojtaba-komeili
Copy link
Contributor Author

Crowdsourcing test failure might be coming from Mephisto.
@JackUrb it seems like Mephisto DB is trying to decode an empty JSON. Was there any recent updates in Mephisto that may cause this?

tests/crowdsourcing/tasks/model_chat/test_model_chat.py:159: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
parlai/crowdsourcing/utils/tests.py:264: in _test_agent_states
    agent_ids = self._register_mock_agents(num_agents=num_agents)
parlai/crowdsourcing/utils/tests.py:170: in _register_mock_agents
    agents = self.db.find_agents()
../Mephisto/mephisto/abstractions/databases/local_database.py:1076: in find_agents
    return [Agent(self, str(r["agent_id"]), row=r) for r in rows]
../Mephisto/mephisto/abstractions/databases/local_database.py:1076: in <listcomp>
    return [Agent(self, str(r["agent_id"]), row=r) for r in rows]
../Mephisto/mephisto/abstractions/providers/mock/mock_agent.py:31: in __init__
    super().__init__(db, db_id, row=row)
../Mephisto/mephisto/data_model/agent.py:73: in __init__
    self.state = AgentState(self)  # type: ignore
../Mephisto/mephisto/abstractions/blueprints/parlai_chat/parlai_chat_agent_state.py:37: in __init__
    self.load_data()
../Mephisto/mephisto/abstractions/blueprints/parlai_chat/parlai_chat_agent_state.py:72: in load_data
    state = json.load(state_json)
/usr/local/lib/python3.7/json/__init__.py:296: in load
    parse_constant=parse_constant, object_pairs_hook=object_pairs_hook, **kw)
/usr/local/lib/python3.7/json/__init__.py:348: in loads
    return _default_decoder.decode(s)
/usr/local/lib/python3.7/json/decoder.py:337: in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <json.decoder.JSONDecoder object at 0x7f326a4d8b10>, s = '', idx = 0

    def raw_decode(self, s, idx=0):
        """Decode a JSON document from ``s`` (a ``str`` beginning with
        a JSON document) and return a 2-tuple of the Python
        representation and the index in ``s`` where the document ended.
    
        This can be used to decode a JSON document from a string that may
        have extraneous data at the end.
    
        """
        try:
            obj, end = self.scan_once(s, idx)
        except StopIteration as err:
>           raise JSONDecodeError("Expecting value", s, err.value) from None
E           json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

/usr/local/lib/python3.7/json/decoder.py:355: JSONDecodeError

@mojtaba-komeili mojtaba-komeili changed the title CircleCI cleaninstall_37 fix CircleCI test failures Apr 16, 2021
requirements.txt Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@JackUrb
Copy link
Contributor

JackUrb commented Apr 16, 2021

Was there any recent updates in Mephisto that may cause this?

This is curious as I've seen this pop up as a phantom error in the last few days, but without any changes that I've made. Possible something is going on, investigating.

This one is a flakey test resolved by facebookresearch/Mephisto#341

requirements.txt Outdated
@@ -35,7 +35,7 @@ scipy==1.4.1
sh==1.12.14
sphinx_rtd_theme==0.4.3
sphinx-autodoc-typehints==1.10.3
Sphinx==2.2.0
Sphinx<4,>=2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was getting 4.0.0b1 for this one. Pre-release again.

@stephenroller stephenroller changed the title CircleCI test failures Dependency bumps to fix cleaninstall CI Apr 17, 2021
@stephenroller stephenroller merged commit 5fff315 into master Apr 17, 2021
@stephenroller stephenroller deleted the circleci-tests branch April 17, 2021 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants