This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Update retrievers.py in RAG #3881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a small error for handling `NaN` value in scores. `scores.fill_(1)` will change all values in scores to 1, while there are values that are not `NaN`.
|
looks good, can you please run cc @stephenroller we need to get precommit setup i believe |
Thanks very much for the instructions! I have reformatted the code using pre-commit |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a small error for handling
NaNvalue in scores.Patch description
scores.fill_(1)will change all values in scores to 1, while there are values that are notNaN.Testing steps
Other information