Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Prevent tensorboardX SummaryWriter from cluttering logs with warnings. #4093

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Prevent tensorboardX SummaryWriter from cluttering logs with warnings. #4093

merged 2 commits into from
Oct 14, 2021

Conversation

kauterry
Copy link
Contributor

Patch description

We remove the invalid characters from the tag name beforehand which the TensorboardX SummaryWriter disallows.

Testing steps

Other information

@kauterry kauterry requested a review from moyapchen October 14, 2021 13:56
moyapchen
moyapchen approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@moyapchen moyapchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel like would be better to sub with some other character if the goal is just to replace ":", but accepting to unblock.

@kauterry kauterry merged commit 92e4fca into main Oct 14, 2021
@kauterry kauterry deleted the krs_summary_writer branch October 14, 2021 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moyapchen moyapchen moyapchen approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kauterry @moyapchen @facebook-github-bot