This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Record task start and end times for Acute-Evals #4208
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricMichaelSmith
changed the base branch from
main
to
EricMichaelSmith-patch-1
December 22, 2021 21:32
EricMichaelSmith
changed the title
[WIP] Record task start and end times for Acute-Evals
Record task start and end times for Acute-Evals
Dec 22, 2021
JackUrb
approved these changes
Dec 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Glad to have start and end times for these! These get_task_start
and get_task_end
functions are likely general enough to live in the underlying StaticAgentState
though.
Good point @JackUrb - just opened up a PR for this at facebookresearch/Mephisto#636 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Record HIT start and end times for Acute-Evals so that Mephisto's DataBrowser can access them. This will allow the Acute-Eval analysis script to record the task completion times properly. NOTE: the actual recording of the start and end times is in Mephisto, as part of facebookresearch/Mephisto#636 : this PR bumps the crowdsourcing CI check to use that update.
Testing steps
Existing tests have been updated to handle this change: the tests will discount the 'time_taken' and 'task_start' columns, which are now (correctly) variable from one run to the next
Testing that HIT times are now saved properly: