Skip to content

Commit

Permalink
fix some tests (#363)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #363

mistakenly imported pvc in last diff

Reviewed By: kittipatv

Differential Revision: D25693999

fbshipit-source-id: 3f9060260cc7ec5f9411a74ce7d2d9015f2cb087
  • Loading branch information
kaiwenw authored and facebook-github-bot committed Dec 25, 2020
1 parent 3262cb8 commit bc11359
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
3 changes: 1 addition & 2 deletions reagent/test/workflow/test_preprocessing.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import unittest

import numpy as np
import pvc
import pytest
from reagent.preprocessing.identify_types import CONTINUOUS

Expand Down Expand Up @@ -49,7 +48,7 @@ def get_random_feature():
num_samples = NUM_ROWS // 2
preprocessing_options = PreprocessingOptions(num_samples=num_samples)

table_spec = TableSpec(dataset=pvc.HiveDataset(table=TABLE_NAME))
table_spec = TableSpec(table_name=TABLE_NAME)

normalization_params = identify_normalization_parameters(
table_spec, COL_NAME, preprocessing_options, seed=self.test_class_seed
Expand Down
3 changes: 1 addition & 2 deletions reagent/test/workflow/test_query_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import unittest

import numpy as np
import pvc
import pytest

# pyre-fixme[21]: Could not find `pyspark`.
Expand Down Expand Up @@ -50,7 +49,7 @@ def generate_data(self, multi_steps=False):
def _discrete_read_data(
self, custom_reward_expression=None, gamma=None, multi_steps=None
):
ts = TableSpec(dataset=pvc.HiveDataset(table=self.table_name))
ts = TableSpec(table_name=self.table_name)
dataset: Dataset = query_data(
input_table_spec=ts,
discrete_action=True,
Expand Down
3 changes: 1 addition & 2 deletions reagent/test/workflow/test_query_data_parametric.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import unittest

import numpy as np
import pvc
import pytest

# pyre-fixme[21]: Could not find `pyspark`.
Expand Down Expand Up @@ -50,7 +49,7 @@ def generate_data(self, multi_steps=False):
def _parametric_read_data(
self, custom_reward_expression=None, gamma=None, multi_steps=None
):
ts = TableSpec(dataset=pvc.HiveDataset(table=self.table_name))
ts = TableSpec(table_name=self.table_name)
dataset: Dataset = query_data(
input_table_spec=ts,
discrete_action=False,
Expand Down

0 comments on commit bc11359

Please sign in to comment.