-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error handling for indexes not supported on GPU? #3269
Labels
Comments
+1 |
The issue here is that wrapped indexes (like IDMap and Pretransform) should be cloned on CPU, that's normal but indexes that contain actual data should be moved to GPU (and the cloning function should throw if this is not the case). |
facebook-github-bot
pushed a commit
that referenced
this issue
Apr 1, 2024
Summary: Issue: #3269 List of implemented GPU indices: https://github.com/facebookresearch/faiss/wiki/Faiss-on-the-GPU#implemented-indexes Differential Revision: D55577576
ramilbakhshyiev
added a commit
that referenced
this issue
Apr 1, 2024
…3336) Summary: Issue: #3269 List of implemented GPU indices: https://github.com/facebookresearch/faiss/wiki/Faiss-on-the-GPU#implemented-indexes Differential Revision: D55577576
ramilbakhshyiev
added a commit
that referenced
this issue
Apr 4, 2024
…3336) Summary: Issue: #3269 List of implemented GPU indices: https://github.com/facebookresearch/faiss/wiki/Faiss-on-the-GPU#implemented-indexes Differential Revision: D55577576
facebook-github-bot
pushed a commit
that referenced
this issue
Apr 4, 2024
…3336) Summary: Issue: #3269 List of implemented GPU indices: https://github.com/facebookresearch/faiss/wiki/Faiss-on-the-GPU#implemented-indexes Reviewed By: junjieqi Differential Revision: D55577576
facebook-github-bot
pushed a commit
that referenced
this issue
Apr 4, 2024
…3336) Summary: Issue: #3269 List of implemented GPU indices: https://github.com/facebookresearch/faiss/wiki/Faiss-on-the-GPU#implemented-indexes Reviewed By: junjieqi Differential Revision: D55577576
ramilbakhshyiev
added a commit
that referenced
this issue
Apr 4, 2024
…3336) Summary: Issue: #3269 List of implemented GPU indices: https://github.com/facebookresearch/faiss/wiki/Faiss-on-the-GPU#implemented-indexes Reviewed By: junjieqi Differential Revision: D55577576
facebook-github-bot
pushed a commit
that referenced
this issue
Apr 4, 2024
…3336) Summary: Issues: #3269 #3024 List of implemented GPU indices: https://github.com/facebookresearch/faiss/wiki/Faiss-on-the-GPU#implemented-indexes Differential Revision: D55577576
ramilbakhshyiev
added a commit
that referenced
this issue
Apr 4, 2024
…3336) Summary: Issues: #3269 #3024 List of implemented GPU indices: https://github.com/facebookresearch/faiss/wiki/Faiss-on-the-GPU#implemented-indexes Differential Revision: D55577576
facebook-github-bot
pushed a commit
that referenced
this issue
Apr 5, 2024
…3336) Summary: Issues: #3269 #3024 List of implemented GPU indices: https://github.com/facebookresearch/faiss/wiki/Faiss-on-the-GPU#implemented-indexes Differential Revision: D55577576
ramilbakhshyiev
added a commit
that referenced
this issue
Apr 5, 2024
…3336) Summary: Issues: #3269 #3024 List of implemented GPU indices: https://github.com/facebookresearch/faiss/wiki/Faiss-on-the-GPU#implemented-indexes Differential Revision: D55577576
facebook-github-bot
pushed a commit
that referenced
this issue
Apr 6, 2024
…3336) Summary: Pull Request resolved: #3336 Issues: #3269 #3024 List of implemented GPU indices: https://github.com/facebookresearch/faiss/wiki/Faiss-on-the-GPU#implemented-indexes Reviewed By: mdouze Differential Revision: D55577576 fbshipit-source-id: 49f490cfba6784661e378acf4de3cce4195bb43b
Fixed in #3336 |
abhinavdangeti
pushed a commit
to blevesearch/faiss
that referenced
this issue
Jul 12, 2024
…acebookresearch#3336) Summary: Pull Request resolved: facebookresearch#3336 Issues: facebookresearch#3269 facebookresearch#3024 List of implemented GPU indices: https://github.com/facebookresearch/faiss/wiki/Faiss-on-the-GPU#implemented-indexes Reviewed By: mdouze Differential Revision: D55577576 fbshipit-source-id: 49f490cfba6784661e378acf4de3cce4195bb43b
aalekhpatel07
pushed a commit
to aalekhpatel07/faiss
that referenced
this issue
Oct 17, 2024
…acebookresearch#3336) Summary: Pull Request resolved: facebookresearch#3336 Issues: facebookresearch#3269 facebookresearch#3024 List of implemented GPU indices: https://github.com/facebookresearch/faiss/wiki/Faiss-on-the-GPU#implemented-indexes Reviewed By: mdouze Differential Revision: D55577576 fbshipit-source-id: 49f490cfba6784661e378acf4de3cce4195bb43b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Currently, the indexes that are supported in GPU are clearly listed in the wiki: https://github.com/facebookresearch/faiss/wiki/Faiss-on-the-GPU#implemented-indexes, however, it would be great if we could throw an error when the user attempts to move an unsupported GPU index instead of failing silently and running in the CPU.
Platform
Faiss version: faiss-gpu 1.7.4
Installed from: conda
Running on:
Interface:
Reproduction instructions
I have created an
IndexPQ
, attempted to move it to the GPU and conducted search. This results in the knn search taking a long time236.77 seconds
plusnvidia-smi pmon
showcases we indeed never use the GPU:In contrast, with an IVFPQ (which is GPU supported) the run time is
3.48 seconds
utilising the same number of vectors and we use the GPU according tonvidia-smi pmon
as expected.The text was updated successfully, but these errors were encountered: