Fix CI (for latest pytest version) #2015
Conversation
facebook-github-bot
added
the
CLA Signed
|
The CI failure on commit b9b3b2f is coming from our jupyter notebook test. I've opened an issue against the |
Jasha10
force-pushed
the
fix-ci-pytest
branch
from
7e07044 to
c2a7d8f
Compare
| _upgrade_basic(session) | ||
| _install_pytest(session) |
There was a problem hiding this comment.
nit: since we need to always install pytest along with the upgrade_basic, could we merge them into one method, something like install_basic?
There was a problem hiding this comment.
I had the same thought, but it turns out that the lint and lint_plugins nox sessions do not require installing pytest (but they do still use upgrade_basic).
There was a problem hiding this comment.
I have just opened PR #2016 which only pins pytest for the jupyter notebook session. I'm thinking of closing this PR in favor of that one. What do you think?
(One benefit of not pinning pytest is that the new pytest version should allow us to move forward with python3.10 support, which is currently blocked).
A new pytest release came out earlier today.