Why is the number of "visual genome" data is different than in the paper? #26
Comments
apsdehal
added a commit
that referenced
this issue
May 8, 2020
Version of OmegaConf used: 2.0.0rc15 Internal implementation of our configuration now uses OmegaConf to build configuration object rather than our configuration implementation. Some salient things to be noticed: - `includes` still stay as it is, we use omegaconf's merge to merge configs recursively in our function now - We are still using our `opt` overload mechanism instead of omegaconf's `merge_with_cli` mechanism to support various usecases of ours. (i) We don't opts to load argparse args (ii) we want to support passing opts via both with space or "=" as separator `training_parameters.log_interval 100` and `training_parameters.log_interval=100`. - We are enabling struct mode by default. This means to update the config on the fly, you will have to use `with omegaconf.open_dict(config)` context to update config after it freezes. This also means reads on non-existing keys won't be allowed. #### Why can't we use 1.4? - 1.4 has typings issues as it doesn't uses standard types for `DictConfig` and `ListConfig` as `collections.abc.Mapping` and `collections.abc.Sequence`. This causes issues in our `isinstance`checks. - 1.4 also has issues with implementations on `hasattr`. See omry/omegaconf#173. So, that it is tracked here, integers as keys are not allowed inside OmegaConf.
apsdehal
added a commit
that referenced
this issue
May 8, 2020
Version of OmegaConf used: 2.0.0rc15 Internal implementation of our configuration now uses OmegaConf to build configuration object rather than our configuration implementation. Some salient things to be noticed: - `includes` still stay as it is, we use omegaconf's merge to merge configs recursively in our function now - We are still using our `opt` overload mechanism instead of omegaconf's `merge_with_cli` mechanism to support various usecases of ours. (i) We don't opts to load argparse args (ii) we want to support passing opts via both with space or "=" as separator `training_parameters.log_interval 100` and `training_parameters.log_interval=100`. - We are enabling struct mode by default. This means to update the config on the fly, you will have to use `with omegaconf.open_dict(config)` context to update config after it freezes. This also means reads on non-existing keys won't be allowed. #### Why can't we use 1.4? - 1.4 has typings issues as it doesn't uses standard types for `DictConfig` and `ListConfig` as `collections.abc.Mapping` and `collections.abc.Sequence`. This causes issues in our `isinstance`checks. - 1.4 also has issues with implementations on `hasattr`. See omry/omegaconf#173. So, that it is tracked here, integers as keys are not allowed inside OmegaConf.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
len(np.load("imdb_genome.npy"))>> 682736But in the paper Tips and Tricks for VQA they said that their number is 485,000 questions. Why is there a difference?
The text was updated successfully, but these errors were encountered: