Fix filepath and save state_dict for model for checkpoint finalize #46
Conversation
facebook-github-bot
added
the
CLA Signed
|
I actually wanted to save the whole model itself for demo purposes. I guess it is fine with weights also. But, we probably should look into why this issue is exactly happening. |
pythia/utils/checkpoint.py
Outdated
| @@ -36,15 +36,14 @@ def __init__(self, trainer): | |||
| self.config["log_foldername"] = self.ckpt_foldername | |||
| self.ckpt_foldername = os.path.join(self.save_dir, self.ckpt_foldername) | |||
| self.pth_filepath = os.path.join( | |||
| self.save_dir, self.ckpt_foldername, | |||
| self.ckpt_foldername, | |||
| self.ckpt_prefix + self.model_name + "_final.pth" | |||
| ) | |||
| self.params_filepath = os.path.join( | |||
There was a problem hiding this comment.
We should remove this line as it doesn't server any purpose now.
|
Upon investigating more I found why we are not being able to save the model as a whole. So the problem is with the We add |
pth_filepathandparams_filepaththat was addingsave_dirtwice in the path.self.trainer.modelwhen tried to save was throwing error. We need to save only the modelstate_dict. Fixes issue Do I need to download the tremendous weights again? #44 error.