small bug in init of top down bottom up #57
Conversation
shubhamagarwal92
commented
May 21, 2019
shubhamagarwal92
commented
- small bug in init of top down bottom up
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
pythia/models/top_down_bottom_up.py
Outdated
| @@ -15,7 +15,7 @@ | |||
| @registry.register_model("top_down_bottom_up") | |||
| class TopDownBottomUp(BaseModel): | |||
| def __init__(self, image_attention_model, text_embedding_models, classifier): | |||
| super(TopDownBottomUpModel, self).__init__() | |||
| super(TopDownBottomUp, self).__init__() | |||
There was a problem hiding this comment.
Can you actually change it to super().__init__()? Since, we are not supporting Pythia 2.x, we should do it in 3.x's way.
There was a problem hiding this comment.
Can you sign the CLA as well? Thanks.
There was a problem hiding this comment.
I actually did! Not showing though
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
* [feature] Add Conceptual Captions Dataset * Address comments
* [feature] Add Conceptual Captions Dataset * Address comments
