Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks for entire models #505

Merged
merged 7 commits into from
Nov 10, 2022
Merged

Conversation

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2022
danthe3rd pushed a commit that referenced this pull request Nov 3, 2022
ghstack-source-id: aa238d5ee5e6b7bd75d499685632a46c89d9cab1
Pull Request resolved: #505
Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

xformers/benchmarks/utils.py Outdated Show resolved Hide resolved
@danthe3rd danthe3rd mentioned this pull request Nov 4, 2022
danthe3rd pushed a commit that referenced this pull request Nov 4, 2022
ghstack-source-id: 75237fcbf4b67cf337698acba781b098742bedd2
Pull Request resolved: #505
danthe3rd pushed a commit that referenced this pull request Nov 4, 2022
ghstack-source-id: befc2ccb84144ce79b4352183facb202adeb5a3d
Pull Request resolved: #505
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Base: 88.01% // Head: 88.01% // No change to project coverage 👍

Coverage data is based on head (59970ef) compared to base (59970ef).
Patch has no changes to coverable lines.

❗ Current head 59970ef differs from pull request most recent head f06f1d9. Consider uploading reports for the commit f06f1d9 to get more accurate results

Additional details and impacted files
@@                  Coverage Diff                  @@
##           gh/danthe3rd/59/base     #505   +/-   ##
=====================================================
  Coverage                 88.01%   88.01%           
=====================================================
  Files                        80       80           
  Lines                      4822     4822           
=====================================================
  Hits                       4244     4244           
  Misses                      578      578           
Flag Coverage Δ
Python 88.01% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

danthe3rd pushed a commit that referenced this pull request Nov 4, 2022
ghstack-source-id: 70eab528b89924c9a4c697888b014fc8e5db1a02
Pull Request resolved: #505
@danthe3rd danthe3rd merged commit f06f1d9 into gh/danthe3rd/59/base Nov 10, 2022
danthe3rd pushed a commit that referenced this pull request Nov 10, 2022
ghstack-source-id: 2c753c3a0a0d3208074d7ff8740b54352fa789cc
Pull Request resolved: #505
@danthe3rd danthe3rd deleted the gh/danthe3rd/59/head branch November 10, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants