Remove support for Python 2 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically Python 2 isn't EOL till 2020, but it is unlikely that there will be any new features for Python 2, maybe bug fixes, but that is most likely it. Anyone dependent on backrefs on Python2 can easily just lock to the last major release, and it will be more than sufficient.
Most new releases moving forward will be to update for later versions of Python and new Unicode versions which will in no way impact Python 2. Feature wise, we are more likely to back off things than implement new features. As Python's Re adds new features, it may replace what we are doing.
Let's be honest as well, I'm pretty sure the actual usage of backrefs (outside of Rummage and wcmatch, which are both my modules) is pretty small.