-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/directives #1777
Feature/directives #1777
Conversation
I'll duplicate this here as well in order to get feedback: Just an overall description of how the current prototype is laid out. I think I'm ready to discuss the syntax.
ExamplesNote with no content
|
We could add the ability for these blocks to insert raw text. That is without an HTML wrapper. Why would we want to do this? Well, IIRC, Python Markdown does not allow HTML except at the root indentation level. So under lists is impossible. This should be pretty straightforward. If we mark a directive as being a text-only directive, we could simply store the content in the Python Markdown's stash and attach the placeholder to the end of the parent We could even add an event that allows you to process the text, such as formatting it for HTML, or just HTML escape it. It's probably the only other case I can think of that people might want to do. EDIT: I don't think we are going to bother with this right now. We don't want to blindly insert text. |
The current syntax is what is up for debate. Do we keep the Myst like approach? Do we do something different? Under the hood, I think the functionality is all there. |
Anyone checking this out should potentially voice their opinion syntax over at Python-Markdown/markdown#1175 as we've already got a good conversation going, but here is fine as well. |
3a7485c
to
248611f
Compare
f99fd12
to
3ac9422
Compare
Chunks are handed to
We allow the same as above for generic blocks, but this would be at least two separate blocks.
|
207be9d
to
328f747
Compare
1a0463b
to
cc222a5
Compare
2588ee6
to
10c9ed2
Compare
- Document missing config stuff. - Document tracking data across blocks. - Switch a number of parts over to generic blocks. - Add custom generic block tool for collapsible code blocks.
- HTML blocks use Emmet style tag and attribute defs - Blocks no longer define `attributes` option, but instead use `$` and take Emmet style attribute defs. - Admonitions and Details no longer define `type` attribute as it is redundant with using `$` to set a class.
08db0c2
to
7377ecd
Compare
fcc48db
to
3d4b55c
Compare
6f53ed4
to
b95f2b6
Compare
0515e26
to
2d4ec56
Compare
@gir-bot lgtm |
Completely experimental. The idea is to (eventually) replace Admonitions, Details, and Tabs with a new directive format.
We won't be killing off replaced legacy extensions, not for some time.
Pros:
Cons:
What are we waiting on?