Fix some display stuff in clock-in graph and controls #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Visual review for your branch is published 🔍Here are the links to: |
eliseo-juan
approved these changes
Jan 28, 2025
Comment on lines
+124
to
+137
| it("should show correct time when clocked out of past clock-ins", () => { | ||
| const mockData = [ | ||
| createMockEntry("09:00", "12:00", "clocked-in"), | ||
| createMockEntry("12:00", "12:00", "clocked-out"), | ||
| ] | ||
|
|
||
| const result = getLabels({ data: mockData, remainingMinutes: 0 }) | ||
|
|
||
| expect(result).toEqual({ | ||
| primaryLabel: "09:00", | ||
| secondaryLabel: "12:00", | ||
| time: "03:00", | ||
| }) | ||
| }) |
There was a problem hiding this comment.
Good job! We need to evolve our tests at the same time!
sauldom102
deleted the
fix-some-display-stuff-in-clockin-graph-and-controls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are a couple of things that I needed to fix regarding the clock-in graph and controls:
What we're seeing while using this component that needs to be fixed:
