Pull request for crawler #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,39 @@ | |||
| import os | |||
| from hashlib import md5 | |||
There was a problem hiding this comment.
This file should possibly be called utils.py
|
|
||
| from scrapy_ft_jobs_sites.settings import CRAWLER_DIR | ||
|
|
||
| MAX_HASH_CHARS = 8 |
There was a problem hiding this comment.
Move this to settings.py
| @@ -37,10 +37,13 @@ def __init__(self, *args, **kwargs): | |||
| self.start_urls.append(URL) | |||
|
|
|||
| for pagination in range(10, 60, 10): | |||
| URL = self.base_url_pattern + item.replace(" ", "+") + "&start=" + str(pagination) | |||
| URL = self.base_url_pattern + \ | |||
| item.replace(" ", "+") + "&start=" + str(pagination) | |||
| self.start_urls.append(URL) | |||
|
|
|||
| def parse_item(self, response): | |||
There was a problem hiding this comment.
Make sure you have test case for parsing logic, this will help making sure our standard is enforced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added crawler to cache Scrapy responses in crawler/services. This generic crawler will write all html response to disk.