Upload artifacts for ffish.js builds in CI #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks |
subvertnormality
pushed a commit
to subvertnormality/Fairy-Stockfish
that referenced
this pull request
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change, I created a new job in ffishjs.yml to automatically build and upload ffish.js so that ffish.js can be built automatically in the CI environment. I used the custom build in https://github.com/yjf2002ghty/Fairy-Stockfish/blob/make_js/.github/workflows/make_js.yml and it works in fairyground by replacing the node module with the custom build. This can avoid setting up environment and build it on our machine and thus saving time.