Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Blink' as detectable rendering engine #246

Closed
brianchirls opened this issue Jun 16, 2017 · 3 comments
Closed

Add 'Blink' as detectable rendering engine #246

brianchirls opened this issue Jun 16, 2017 · 3 comments

Comments

@brianchirls
Copy link

Chrome has been off WebKit and using its own fork Blink for some time now, since v28.

I understand there are two ways to detect Blink, though I'm not sure how reliable they are:

  • /Chrome\/[0-9\.]+/ - see MDN
  • /WebKit\/537\.36/ - This one mostly seems to check out, per this Chrome Version History, except for Chrome 27, which actually used WebKit 537.36.

It's worth mentioning that Chrome on iOS still uses WebKit.

@brianchirls
Copy link
Author

It looks like the version number for Blink never progresses beyond 537.36, so it might make sense to just report whatever the Chrome version number is.

@mrkishi
Copy link

mrkishi commented Sep 30, 2017

What about reporting Chrome >= 28 as Blink?

Perhaps something along these lines:

[/(chrome)\/((?:2[89]\.|[3-9]\d\.|\d{3}\.)[\w\.]+)/i, [[NAME, 'Blink'], [VERSION]]

I think it'd work fine for most Chromium-based browsers, too.

@AnandChowdhary
Copy link

I agree. Most active Chrome versions use Blink, not WebKit. Other user agent parsing libraries report it as Blink as well, I think we should be consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants