Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Oculus Browser #247

Closed
brianchirls opened this issue Jun 20, 2017 · 3 comments
Closed

Add Oculus Browser #247

brianchirls opened this issue Jun 20, 2017 · 3 comments
Labels
Enhancement

Comments

@brianchirls
Copy link

Here's a sample user agent string:
Mozilla/5.0 (Linux; Android 7.0; SM-G920I Build/NRD90M) AppleWebKit/537.36 (KHTML, like Gecko) OculusBrowser/3.4.9 SamsungBrowser/4.0 Chrome/57.0.2987.146 Mobile VR Safari/537.36

Now this gets reported as Android Browser 4.0, but it should be Oculus Browser 3.4.9, running Blink 57.0.2987 (see #246). Device and OS info are correct.
@ebbmo
Copy link

ebbmo commented Jun 20, 2017

Hi brianchirls,
Good find - do you mind open a PR for it (tests included)?
KR, ebbmo

@brianchirls
Copy link
Author

Sure. I was able to get it working as an extension, so I don't think it would be too much trouble to make a PR.

@ebbmo
Copy link

ebbmo commented Jun 20, 2017

Perfect! :)

faisalman added a commit that referenced this issue Nov 22, 2018
@faisalman
Fix #246 #247 - Add Engine: Blink
3a5a701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@faisalman @brianchirls @ebbmo