chore: apply suggestions

faker-js · Aug 19, 2022 · 560a543 · 560a543
1 parent 4952b22
commit 560a543
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 12 deletions.
diff --git a/src/modules/name/index.ts b/src/modules/name/index.ts
@@ -291,7 +291,7 @@ export class Name {
    * faker.name.sexType() // Sex.Female
    */
   sexType(): SexType {
-    return this.faker.helpers.arrayElement(Object.values(Sex));
+    return this.faker.helpers.objectValue(Sex);
   }
 
   /**

diff --git a/test/__snapshots__/name.spec.ts.snap b/test/__snapshots__/name.spec.ts.snap
@@ -54,9 +54,7 @@ exports[`name > 42 > sex > noArgs 1`] = `"female"`;
 
 exports[`name > 42 > sex > with gender 1`] = `"female"`;
 
-exports[`name > 42 > sexType > noArgs 1`] = `"female"`;
-
-exports[`name > 42 > sexType > with gender 1`] = `"female"`;
+exports[`name > 42 > sexType 1`] = `"female"`;
 
 exports[`name > 42 > suffix > noArgs 1`] = `"III"`;
 
@@ -116,9 +114,7 @@ exports[`name > 1211 > sex > noArgs 1`] = `"male"`;
 
 exports[`name > 1211 > sex > with gender 1`] = `"male"`;
 
-exports[`name > 1211 > sexType > noArgs 1`] = `"male"`;
-
-exports[`name > 1211 > sexType > with gender 1`] = `"male"`;
+exports[`name > 1211 > sexType 1`] = `"male"`;
 
 exports[`name > 1211 > suffix > noArgs 1`] = `"DVM"`;
 
@@ -178,9 +174,7 @@ exports[`name > 1337 > sex > noArgs 1`] = `"female"`;
 
 exports[`name > 1337 > sex > with gender 1`] = `"female"`;
 
-exports[`name > 1337 > sexType > noArgs 1`] = `"female"`;
-
-exports[`name > 1337 > sexType > with gender 1`] = `"female"`;
+exports[`name > 1337 > sexType 1`] = `"female"`;
 
 exports[`name > 1337 > suffix > noArgs 1`] = `"I"`;
 

diff --git a/test/name.spec.ts b/test/name.spec.ts
@@ -11,7 +11,7 @@ describe('name', () => {
   });
 
   seededTests(faker, 'name', (t) => {
-    t.itEach('jobTitle', 'jobDescriptor', 'jobArea', 'jobType');
+    t.itEach('sexType', 'jobTitle', 'jobDescriptor', 'jobArea', 'jobType');
 
     t.describeEach(
       'firstName',
@@ -20,7 +20,6 @@ describe('name', () => {
       'gender',
       'prefix',
       'sex',
-      'sexType',
       'suffix'
     )((t) => t.it('noArgs').it('with gender', 'male'));