Skip to content

Commit

Permalink
updated
Browse files Browse the repository at this point in the history
  • Loading branch information
SaurabhXRT committed Jun 5, 2024
1 parent 1367342 commit 5b9b787
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
10 changes: 5 additions & 5 deletions docs/guide/upgrading.md
Original file line number Diff line number Diff line change
Expand Up @@ -484,12 +484,12 @@ Renamed deprecated locale aliases `cz`, `en_IND`, `ge` and removed `global`.

The following locale definitions have been renamed to use singular keys and file names:

| Old | Replacement |
| ----------------------------------------- | ------------------------------------------- |
| Old | Replacement |
| ------------------------------------------- | -------------------------------------------- |
| `faker.definitions.science.chemicalElement` | `faker.definitions.science.chemical_element` |
| `faker.definitions.system.directoryPaths` | `faker.definitions.system.directory_path` |
| `faker.definitions.system.mimeTypes` | `faker.definitions.system.mime_type` |
| `faker.definitions.lorem.words` | `faker.definitions.lorem.word` |
| `faker.definitions.system.directoryPaths` | `faker.definitions.system.directory_path` |
| `faker.definitions.system.mimeTypes` | `faker.definitions.system.mime_type` |
| `faker.definitions.lorem.words` | `faker.definitions.lorem.word` |

With that now all our locale data use the following naming scheme:

Expand Down
2 changes: 1 addition & 1 deletion pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions test/modules/lorem.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe('lorem', () => {

expect(actual).toBeTruthy();
expect(actual).toBeTypeOf('string');
expect(faker.definitions.lorem.words).toContain(actual);
expect(faker.definitions.lorem.word).toContain(actual);
});

// INFO @Shinigami92 2022-02-11: Seems there are only words with a max length of 14 characters
Expand All @@ -54,7 +54,7 @@ describe('lorem', () => {

expect(actual).toBeTruthy();
expect(actual).toBeTypeOf('string');
expect(faker.definitions.lorem.words).toContain(actual);
expect(faker.definitions.lorem.word).toContain(actual);
expect(actual).toHaveLength(length);
}
);
Expand All @@ -72,7 +72,7 @@ describe('lorem', () => {
expect(words).toHaveLength(3);

for (const word of words) {
expect(faker.definitions.lorem.words).toContain(word);
expect(faker.definitions.lorem.word).toContain(word);
}
});

Expand All @@ -89,7 +89,7 @@ describe('lorem', () => {
expect(words).toHaveLength(num);

for (const word of words) {
expect(faker.definitions.lorem.words).toContain(word);
expect(faker.definitions.lorem.word).toContain(word);
}
}
);
Expand Down

0 comments on commit 5b9b787

Please sign in to comment.