Skip to content

Commit

Permalink
refactor(locale): improve product_name data in en and tr (#3372)
Browse files Browse the repository at this point in the history
* Reclassify 'Soft', 'Fresh', and 'Frozen' as adjectives in en locale

* Add extra materials in en

* Move some materials to adjectives for better categorization in tr

* Add extra data to materials in tr

* Run preflight
  • Loading branch information
k-salih authored Jan 15, 2025
1 parent 6ec6f84 commit 773fc1f
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 13 deletions.
12 changes: 9 additions & 3 deletions src/locales/en/commerce/product_name.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ export default {
'Elegant',
'Ergonomic',
'Fantastic',
'Fresh',
'Frozen',
'Generic',
'Gorgeous',
'Handcrafted',
Expand All @@ -22,20 +24,24 @@ export default {
'Rustic',
'Sleek',
'Small',
'Soft',
'Tasty',
'Unbranded',
],
material: [
'Aluminum',
'Bamboo',
'Bronze',
'Ceramic',
'Concrete',
'Cotton',
'Fresh',
'Frozen',
'Gold',
'Granite',
'Marble',
'Metal',
'Plastic',
'Rubber',
'Soft',
'Silk',
'Steel',
'Wooden',
],
Expand Down
12 changes: 9 additions & 3 deletions src/locales/tr/commerce/product_name.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
export default {
adjective: [
'Dondurulmuş',
'El Yapımı',
'El Üretimi',
'Ergonomik',
Expand All @@ -14,22 +15,27 @@ export default {
'Mükemmel',
'Pratik',
'Rafine',
'Taze',
'Yumuşak',
'Zeki',
'İnanılmaz',
'Şık',
],
material: [
'Ahşap',
'Altın',
'Alüminyum',
'Bambu',
'Beton',
'Dondurulmuş',
'Granit',
'Kauçuk',
'Mermer',
'Metal',
'Pamuk',
'Plastik',
'Taze',
'Yumuşak',
'Seramik',
'Çelik',
'İpek',
],
product: [
'Araba',
Expand Down
14 changes: 7 additions & 7 deletions test/modules/__snapshots__/commerce.spec.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ exports[`commerce > 42 > productAdjective 1`] = `"Handcrafted"`;

exports[`commerce > 42 > productDescription 1`] = `"New salmon Pants with ergonomic design for crushing comfort"`;

exports[`commerce > 42 > productMaterial 1`] = `"Frozen"`;
exports[`commerce > 42 > productMaterial 1`] = `"Cotton"`;

exports[`commerce > 42 > productName 1`] = `"Handcrafted Wooden Sausages"`;

Expand Down Expand Up @@ -66,9 +66,9 @@ exports[`commerce > 1211 > product 1`] = `"Towels"`;

exports[`commerce > 1211 > productAdjective 1`] = `"Tasty"`;

exports[`commerce > 1211 > productDescription 1`] = `"Small Cheese designed with Wooden for right performance"`;
exports[`commerce > 1211 > productDescription 1`] = `"Soft Cheese designed with Wooden for right performance"`;

exports[`commerce > 1211 > productMaterial 1`] = `"Wooden"`;
exports[`commerce > 1211 > productMaterial 1`] = `"Steel"`;

exports[`commerce > 1211 > productName 1`] = `"Tasty Steel Cheese"`;

Expand Down Expand Up @@ -100,10 +100,10 @@ exports[`commerce > 1337 > price > with min option 1`] = `"293.09"`;

exports[`commerce > 1337 > product 1`] = `"Chicken"`;

exports[`commerce > 1337 > productAdjective 1`] = `"Generic"`;
exports[`commerce > 1337 > productAdjective 1`] = `"Frozen"`;

exports[`commerce > 1337 > productDescription 1`] = `"Innovative Car featuring lawful technology and Fresh construction"`;
exports[`commerce > 1337 > productDescription 1`] = `"Innovative Car featuring lawful technology and Concrete construction"`;

exports[`commerce > 1337 > productMaterial 1`] = `"Fresh"`;
exports[`commerce > 1337 > productMaterial 1`] = `"Ceramic"`;

exports[`commerce > 1337 > productName 1`] = `"Generic Concrete Chicken"`;
exports[`commerce > 1337 > productName 1`] = `"Frozen Bronze Chicken"`;

0 comments on commit 773fc1f

Please sign in to comment.