Merge branch 'next' into fix/rm-fictional-cities-ne-ro-tr

faker-js · May 3, 2023 · 99d4f5c · 99d4f5c
2 parents 9c4af9a + ede6ffa
commit 99d4f5c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/test/helpers.spec.ts b/test/helpers.spec.ts
@@ -791,9 +791,8 @@ describe('helpers', () => {
         });
 
         it('empty array returns empty array', () => {
-          const input = [];
           const length = faker.number.int({ min: 1, max: 6 });
-          const unique = faker.helpers.uniqueArray(input, length);
+          const unique = faker.helpers.uniqueArray([], length);
           expect(unique).toHaveLength(0);
         });
 

diff --git a/test/scripts/apidoc/signature.example.ts b/test/scripts/apidoc/signature.example.ts
@@ -94,7 +94,7 @@ export class SignatureTest {
    * @param b The string parameter.
    */
   optionalStringParamMethod(b?: string): number {
-    return +b;
+    return b ? 0 : 1;
   }
 
   /**
@@ -114,7 +114,7 @@ export class SignatureTest {
    * @param c The boolean parameter.
    */
   multiParamMethod(a: number, b?: string, c: boolean = true): number {
-    return c ? a : +b;
+    return c ? a : b ? 0 : 1;
   }
 
   /**
@@ -143,7 +143,7 @@ export class SignatureTest {
       excludes?: ReadonlyArray<AlphaNumericChar>;
     }
   ): string {
-    return value + options.format;
+    return options?.format ?? value;
   }
 
   /**
@@ -195,7 +195,7 @@ export class SignatureTest {
      */
     e: LiteralUnion<'a' | 'b'>;
   }): number {
-    return options.c ? options.a : +options.b;
+    return options.a;
   }
 
   /**

diff --git a/test/support/seededRuns.ts b/test/support/seededRuns.ts
@@ -34,7 +34,7 @@ type NoArgsMethodOf<ObjectType> = MethodOf<ObjectType> &
   {
     [Key in MethodOf<ObjectType, () => unknown>]: ObjectType[Key] extends (
       arg0: string | number | boolean | Record<string, undefined>,
-      ...args
+      ...args: unknown[]
     ) => unknown
       ? Key
       : never;

diff --git a/vite.config.ts b/vite.config.ts
@@ -11,6 +11,7 @@ export default defineConfig({
     setupFiles: ['test/setup.ts'],
     coverage: {
       all: true,
+      provider: 'c8',
       reporter: ['clover', 'cobertura', 'lcov', 'text'],
       include: ['src'],
     },