Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate datatype.json() and datatype.array() for removal #1851

Closed
ST-DDT opened this issue Feb 16, 2023 · 0 comments · Fixed by #1852 or #1853
Closed

Deprecate datatype.json() and datatype.array() for removal #1851

ST-DDT opened this issue Feb 16, 2023 · 0 comments · Fixed by #1852 or #1853
Assignees
@xDivisionByZerox
Labels
c: chore PR that doesn't affect the runtime behavior deprecation A deprecation was made in the PR m: datatype Something is referring to the datatype module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v8.x

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Feb 16, 2023

Clear and concise description of the problem

The methods return data that are most likely useless for the users as it contains arbritary data.

Suggested solution

Deprecate the method and recommend helpers.multiple (for datatype.array) and a self built method for datatype.json.

Alternative

No response

Additional context

We decided that we don't want to return random "dynamic" objects from our API unless the user explicitly passed the inputs for the method: #1733 (comment)
@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug m: datatype Something is referring to the datatype module deprecation A deprecation was made in the PR labels Feb 16, 2023
@ST-DDT ST-DDT moved this to Todo in Faker Roadmap Feb 16, 2023
@xDivisionByZerox xDivisionByZerox self-assigned this Feb 16, 2023
This was referenced Feb 16, 2023
Merged
Merged
@ejcheng ejcheng moved this from Todo to In Progress in Faker Roadmap Feb 17, 2023
This was linked to pull requests Feb 17, 2023
refactor(datatype): deprecate json #1852
Merged
refactor(datatype): deprecate array #1853
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Faker Roadmap Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xDivisionByZerox xDivisionByZerox

Labels
c: chore PR that doesn't affect the runtime behavior deprecation A deprecation was made in the PR m: datatype Something is referring to the datatype module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
2 participants
@ST-DDT @xDivisionByZerox