Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(datatype): deprecate array #1853

Merged
merged 7 commits into from
Feb 19, 2023
Merged

refactor(datatype): deprecate array #1853

merged 7 commits into from
Feb 19, 2023

Conversation

xDivisionByZerox
Copy link
Member

Part of #1851.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: datatype Something is referring to the datatype module deprecation A deprecation was made in the PR labels Feb 16, 2023
@xDivisionByZerox xDivisionByZerox requested a review from a team February 16, 2023 22:03
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner February 16, 2023 22:03
@xDivisionByZerox xDivisionByZerox self-assigned this Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023 •
edited
Loading

Codecov Report

Merging #1853 (fb17b73) into next (fccd641) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1853   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2346     2346           
  Lines      236480   236489    +9     
  Branches     1148     1150    +2     
=======================================
+ Hits       235615   235632   +17     
+ Misses        843      835    -8     
  Partials       22       22
Impacted Files Coverage Δ
src/modules/datatype/index.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 94.67% <0.00%> (+2.36%) ⬆️

@xDivisionByZerox xDivisionByZerox changed the title refactor(datatype): deprecate array refactor(datatype): deprecate array Feb 16, 2023
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Feb 16, 2023
@xDivisionByZerox xDivisionByZerox requested review from a team and ST-DDT February 16, 2023 23:55
ST-DDT
ST-DDT reviewed Feb 17, 2023
View reviewed changes
@xDivisionByZerox xDivisionByZerox linked an issue Feb 17, 2023 that may be closed by this pull request
Deprecate datatype.json() and datatype.array() for removal #1851
Closed
ST-DDT
ST-DDT previously approved these changes Feb 17, 2023
View reviewed changes
@ST-DDT ST-DDT requested a review from a team February 17, 2023 11:50
Shinigami92
Shinigami92 previously approved these changes Feb 17, 2023
View reviewed changes
matthewmayer
matthewmayer previously requested changes Feb 17, 2023
View reviewed changes
@xDivisionByZerox xDivisionByZerox dismissed stale reviews from Shinigami92 and ST-DDT via e0ae976 February 17, 2023 12:31
@ST-DDT ST-DDT merged commit 54faf53 into next Feb 19, 2023
@ST-DDT ST-DDT deleted the refactor/datatype/deprecate-array branch February 19, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ejcheng ejcheng ejcheng approved these changes

@matthewmayer matthewmayer Awaiting requested review from matthewmayer

Assignees

@xDivisionByZerox xDivisionByZerox

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs deprecation A deprecation was made in the PR m: datatype Something is referring to the datatype module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

Deprecate datatype.json() and datatype.array() for removal
5 participants
@xDivisionByZerox @matthewmayer @ST-DDT @Shinigami92 @ejcheng