-
-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(locale): remove unrealistic fictional city patterns in ne, ro, tr #2120
fix(locale): remove unrealistic fictional city patterns in ne, ro, tr #2120
Conversation
example: West Vladcester Bökeshire Manishacester
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2120 +/- ##
==========================================
- Coverage 99.60% 99.60% -0.01%
==========================================
Files 2605 2605
Lines 244968 244926 -42
Branches 1256 1254 -2
==========================================
- Hits 243998 243949 -49
- Misses 943 950 +7
Partials 27 27
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me.
Do those prefixes/suffixes simply not exist in our dataset or is the concept itself non existing in the locale? Do you have any info on that? If that should be the case, please export |
I'd imagine most languages would have certain prefixes or suffixes which might appear commonly in city names If someone who knows more about the language comes by later they could add back some new fictional patterns with appropriate suffixes and prefixes. But for now, just using the real city names seems superior. |
Removes fictional patterns in three locales where location.city_name is available but there are no native city prefixes/suffixes available.
Avoids weird combinations of ne/ro/tr names with English prefixes/suffixes like
West Vladcester
Bökeshire
Manishacester