Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document npm scripts #322

Closed
ST-DDT opened this issue Jan 27, 2022 · 4 comments · Fixed by #2095
Closed

Document npm scripts #322

ST-DDT opened this issue Jan 27, 2022 · 4 comments · Fixed by #2095
Assignees
Labels
c: docs Improvements or additions to documentation c: feature Request for new feature p: 1-normal Nothing urgent
Milestone

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Jan 27, 2022

We should document

  • which script should be run by humans in which order
  • which scripts are required by CI/netlify-toml
  • which are "just" sub-scripts

Potentially a part of #308

Originally posted by @Shinigami92 in #289 (comment)

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation c: feature Request for new feature labels Jan 27, 2022
@Shinigami92 Shinigami92 moved this to Todo in Faker Roadmap Jan 27, 2022
@Shinigami92 Shinigami92 added the p: 1-normal Nothing urgent label Mar 23, 2022
@Shinigami92 Shinigami92 changed the title Improve and document node aliases for humans Document npm scripts Sep 2, 2022
@ST-DDT ST-DDT modified the milestones: v7 - Current Major, vFuture Sep 8, 2022
@xDivisionByZerox
Copy link
Member

This has been made a lot simpler #1846, because preflight is now the only script that needs to be run by a human.

In which form should the documentation be provided?

@matthewmayer
Copy link
Contributor

Could probably expand the line in CONTRIBUTING which says:

Please make sure that you run pnpm run preflight before making a PR to ensure that everything is working from the start.

To something like

Please make sure that you run `pnpm run preflight` before making a PR to ensure that everything is working from the start. This is a shorthand for running the following scripts in order:
- `pnpm install` - installs npm modules defined in package.json
- `pnpm run generate:locales` - generates locale files
- `pnpm run generate:api-doc` - generates API documentation
- `pnpm run format` - runs prettify to format code
- `pnpm run lint` - runs ESLint
- `pnpm run build` - builds the code, both CommonJS and ESM versions
- `pnpm run test:update-snapshots ` - runs all tests, and updates any snapshots if needed
- `pnpm run ts-check` - checks TypeScript

@xDivisionByZerox
Copy link
Member

That is a really good idea.

Do you want to open a PR to make this change? Otherwise, I can do one and add you as a co-author.

@matthewmayer
Copy link
Contributor

you go ahead? you may be able to write nicer descriptions. i wasn't too clear what pnpm run ts-check actually does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation c: feature Request for new feature p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants