Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add npm script descriptions to CONTRIBUTING #2095

Merged
merged 4 commits into from
Apr 26, 2023
Merged

docs: add npm script descriptions to CONTRIBUTING #2095

merged 4 commits into from
Apr 26, 2023

Conversation

xDivisionByZerox
Copy link
Member

Closes #322.

Original content from @matthewmayer in #322 (comment).

@xDivisionByZerox xDivisionByZerox added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Apr 25, 2023
@xDivisionByZerox xDivisionByZerox added this to the vFuture milestone Apr 25, 2023
@xDivisionByZerox xDivisionByZerox self-assigned this Apr 25, 2023
@xDivisionByZerox xDivisionByZerox requested a review from a team April 25, 2023 17:10
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner April 25, 2023 17:10
@codecov
Copy link

codecov bot commented Apr 25, 2023 •
edited
Loading

Codecov Report

Merging #2095 (869199c) into next (4d0458c) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 869199c differs from pull request most recent head d571633. Consider uploading reports for the commit d571633 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2095      +/-   ##
==========================================
- Coverage   99.59%   99.59%   -0.01%     
==========================================
  Files        2567     2567              
  Lines      243328   243364      +36     
  Branches     1251     1250       -1     
==========================================
+ Hits       242347   242367      +20     
- Misses        954      970      +16     
  Partials       27       27

see 3 files with indirect coverage changes

Shinigami92
Shinigami92 reviewed Apr 25, 2023
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with that, but it might not get updated if we forget it when changing something in the preflight command itself

CONTRIBUTING.md Outdated Show resolved Hide resolved
@xDivisionByZerox xDivisionByZerox requested a review from a team April 25, 2023 18:38
matthewmayer
matthewmayer previously approved these changes Apr 26, 2023
View reviewed changes
@Shinigami92 Shinigami92 enabled auto-merge (squash) April 26, 2023 17:41
@Shinigami92 Shinigami92 merged commit 5ad55a5 into next Apr 26, 2023
@Shinigami92 Shinigami92 deleted the docs/npm-scripts branch May 1, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT left review comments

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

@ejcheng ejcheng ejcheng approved these changes

Assignees

@xDivisionByZerox xDivisionByZerox

Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
vFuture
Development

Successfully merging this pull request may close these issues.

Document npm scripts
5 participants
@xDivisionByZerox @matthewmayer @ST-DDT @Shinigami92 @ejcheng