-
-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fake (generated) images for faker opposed to real people #465
Comments
IMO the avatar should return an actual/fake avatar instead of a persons face. |
You could potentially use identicons (which is what github uses) which is actually a hash based on username: https://github.com/stewartlord/identicon.js The images could be generated from your list of fake names. I'd count this as a bonus since it could potentially allow for easier debugging (Alice/Bob/Camerons are always going to be associated with the same image). |
We have some cases where real face images are needed, so a option to choose what type of avatar you want would be the best option |
Or at least provide an additional api, so we have |
While this is an issue, I'm going to advocate for user images to be taken from across the race / gender spectrum. The current avatars are primarily white and male |
@Shinigami92 Should this be v6.2 or v7? I'm leaning towards v7, but I'll let you make the final decision |
I think we should not tag this for 6.2 as it is a major change in behavior. |
Yeah, I think the |
I think a fairly easy way to do this while nsuring a diverse set of images would be:
faker.helpers.fake(`profile picture of a {{number.int({"min":18, "max":80})}}-year-old {{person.sex}} from {{location.country}}`);
This should only be an hour or two's work. |
I tried generating 100 images with Stable Diffusion 3 (50 male, 50 female) They can be accessed like this: Code i used to generate is at https://github.com/matthewmayer/sd3-avatars |
Looks like a good solution. We have to check the TOS though. |
Nice! Great starting point. Didn't exactly hit the mark on diversity though. Maybe 4-5 ethnically ambiguous people in the males + the last 2 that looked intentional (one Black guy and one South Asian) Might seem overbearing; but from a product perspective- why limit your market |
Made a new branch https://github.com/matthewmayer/sd3-avatars/tree/country-prompt where i append a random These folks seem more diverse. |
Awesome! Good job Stable diffusion for not being offensively stereotypical. LGTM, including the guy that's too cool for a shirt in a profile picture |
If we use jsdelivr, we have to add a link to their TOS to each method returing their links: |
Would we want to make this a new method like avatarAI() and then have avatar() pick between avatarAI() and avatarGithub()? |
We could also think about to directly go to how these images are more target to -> person module. |
I'm not sure whether I would name it avatar. Or should portraits have a blank background? We could still add them as a possibility to avatar. And add a link to the method in the person module's description. |
I think |
portraits! That was the word I missed in my head. I (/ my previous Company) need them like the images were generated by @matthewmayer. More or less frontal/orthogonal portraits of human faces. Detecting landmarks, analyzing ethicality, age and gender. The company has tools on their own to extract the human out of the image and therefore remove the background. |
Blocked by #3131 next step is to set up the assets repo |
We now use AI generated images instead. The feature will be available in the next update: |
Describe the bug
It looks like the faker images are just using some scraped profile list from ages back, and stored on a cloudflare bucket
https://cloudflare-ipfs.com/ipfs/Qmd3W5DuhgHirLHGVixi6V76LhCkZUz6pnFt5AJBiyvHye/avatar/<number>.jpg
Opposed to using real images (I recognized one of the people lol), faker should maybe use fake images.
Some ideas are
I would suggest just overwriting the cloudflare images (that way you have backwards compatibility, and you are no longer exposing the images). For that, you need to find the maintainer of the bucket (and also maybe build in some redundancy? I think this community is probably familiar with maverick devs), which looks like bogus, so I opened an issue there too.
Marked as a bug, because you should fix this (even though you are not directly responsible for the images)- I don't think it's responsible to be posting pictures of 1250 random people without their consent.
Reproduction
Additional Info
Tracking down the source of the initial images see:
The text was updated successfully, but these errors were encountered: