-
-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(image): add AI-generated avatars #3126
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3126 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 2811 2811
Lines 216952 216965 +13
Branches 941 942 +1
=======================================
+ Hits 216899 216914 +15
+ Misses 53 51 -2
|
As you wrote in the comment. We would like to host these images inside the faker org so we dont loose access to them again. The idea is to use a separate asset repository (to avoid bloating the main repo) and to put the images there but we didnt have enough time yet to plan the exact structure. |
When we later store the images in the faker org, we should also place a file for each image with meta data, including: "used model, prompt, negative prompt, seed, parameters, ..." |
Lets put the technical discussion of what to put where and how in a separate issue. |
Yep. I'd suggest say faker-media as repo name (in case we want video or audio later), then (versioned?) subfolders for different methods (we might want e.g. dummy company logos in the future). The most important thing is that urls are stable as once the urls are generated they might be stored in a database so we want them accessible "forever". |
updated to new method name and the newly generated assets in faker-js/assets-person-portrait#1 |
Co-authored-by: ST-DDT <[email protected]>
Co-authored-by: ST-DDT <[email protected]>
Co-authored-by: ST-DDT <[email protected]>
Co-authored-by: ST-DDT <[email protected]>
i will leave this PR in draft until faker-js/assets-person-portrait#1 is merged, then update the URLs to the final ones. |
1 similar comment
i will leave this PR in draft until faker-js/assets-person-portrait#1 is merged, then update the URLs to the final ones. |
FYI: I plan to release the next version after this is merged, or are there other PRs that should be merged as well? |
Draft PR to explore the best API for this. CDN URL will need to be replaced with final one.
Uses 100 male and 100 female images generated as part of discussion here #465 (comment)
fix #465
fix #2173