-
-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: relink main to next #1435
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1435 +/- ##
=======================================
Coverage 99.61% 99.62%
=======================================
Files 2166 2166
Lines 237450 237450
Branches 1040 1041 +1
=======================================
+ Hits 236543 236550 +7
+ Misses 886 879 -7
Partials 21 21
|
Do we need to change the ci trigger here to? faker/.github/workflows/ci.yml Lines 3 to 7 in 8bf7162
|
YES we do! Good catch |
Looks like you want to discuss again about the (new) schema? |
That was not my intention. I cancelled the auto merge and it changed the title back... |
Wasn't entirely sure. That's why I asked^^
I don't see how this is related to this PR, but sure let's discuss it tomorrow (but as stated in Discord I'm really unattached to that topic). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the "main" here? Or is this a job name?
faker/.github/workflows/semantic-pull-request.yml
Lines 10 to 15 in 8bf7162
permissions: {} | |
jobs: | |
main: | |
permissions: | |
pull-requests: read # to analyze PRs (amannn/action-semantic-pull-request) | |
statuses: write # to mark status of analyzed PR (amannn/action-semantic-pull-request) |
Yes, that's just a name |
Okay, just checking |
We renamed the
main
branch tonext
, therefore we now need to fix some links