Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: relink main to next #1435

Merged
merged 2 commits into from
Oct 13, 2022
Merged

infra: relink main to next #1435

merged 2 commits into from
Oct 13, 2022

Conversation

Shinigami92
Copy link
Member

We renamed the main branch to next, therefore we now need to fix some links

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Oct 12, 2022
@Shinigami92 Shinigami92 self-assigned this Oct 12, 2022
@Shinigami92 Shinigami92 requested a review from a team October 12, 2022 12:35
@Shinigami92 Shinigami92 requested a review from a team as a code owner October 12, 2022 12:35
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #1435 (9c96dbe) into next (8bf7162) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1435   +/-   ##
=======================================
  Coverage   99.61%   99.62%           
=======================================
  Files        2166     2166           
  Lines      237450   237450           
  Branches     1040     1041    +1     
=======================================
+ Hits       236543   236550    +7     
+ Misses        886      879    -7     
  Partials       21       21           
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 83.59% <0.00%> (+1.85%) ⬆️

@Shinigami92 Shinigami92 requested a review from a team October 12, 2022 12:51
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup and removed c: chore PR that doesn't affect the runtime behavior labels Oct 12, 2022
@Shinigami92 Shinigami92 changed the title chore: relink main to next infra: relink main to next Oct 12, 2022
ST-DDT
ST-DDT previously approved these changes Oct 12, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) October 12, 2022 12:52
@xDivisionByZerox
Copy link
Member

Do we need to change the ci trigger here to?

on:
push:
branches:
- main
pull_request:

@ST-DDT ST-DDT disabled auto-merge October 12, 2022 13:19
@ST-DDT ST-DDT changed the title infra: relink main to next chore: relink main to next Oct 12, 2022
@Shinigami92
Copy link
Member Author

Do we need to change the ci trigger here to?

on:
push:
branches:
- main
pull_request:

YES we do! Good catch

@Shinigami92
Copy link
Member Author

Shinigami92 commented Oct 12, 2022

@ST-DDT

Looks like you want to discuss again about the (new) schema?
Or in other words: @xDivisionByZerox what is your plan how to structure the new changelog(s)?
We might want to discuss this in tomorrows meeting

@ST-DDT
Copy link
Member

ST-DDT commented Oct 12, 2022

That was not my intention. I cancelled the auto merge and it changed the title back...

@xDivisionByZerox
Copy link
Member

YES we do! Good catch

Wasn't entirely sure. That's why I asked^^

Or in other words: @xDivisionByZerox what is your plan how to structure the new changelog(s)?

I don't see how this is related to this PR, but sure let's discuss it tomorrow (but as stated in Discord I'm really unattached to that topic).

@Shinigami92 Shinigami92 changed the title chore: relink main to next infra: relink main to next Oct 12, 2022
@Shinigami92 Shinigami92 requested a review from ST-DDT October 12, 2022 14:03
@Shinigami92 Shinigami92 enabled auto-merge (squash) October 12, 2022 15:05
Copy link
Member

@ejcheng ejcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the "main" here? Or is this a job name?

permissions: {}
jobs:
main:
permissions:
pull-requests: read # to analyze PRs (amannn/action-semantic-pull-request)
statuses: write # to mark status of analyzed PR (amannn/action-semantic-pull-request)

@Shinigami92
Copy link
Member Author

What about the "main" here? Or is this a job name?

permissions: {}
jobs:
main:
permissions:
pull-requests: read # to analyze PRs (amannn/action-semantic-pull-request)
statuses: write # to mark status of analyzed PR (amannn/action-semantic-pull-request)

Yes, that's just a name

@Shinigami92 Shinigami92 requested review from ejcheng and a team October 12, 2022 19:15
@Shinigami92 Shinigami92 requested a review from a team October 12, 2022 19:15
@ejcheng
Copy link
Member

ejcheng commented Oct 12, 2022

What about the "main" here? Or is this a job name?

permissions: {}
jobs:
main:
permissions:
pull-requests: read # to analyze PRs (amannn/action-semantic-pull-request)
statuses: write # to mark status of analyzed PR (amannn/action-semantic-pull-request)

Yes, that's just a name

Okay, just checking

@Shinigami92 Shinigami92 merged commit 2c9622b into next Oct 13, 2022
@ejcheng ejcheng deleted the relink-main-to-next branch October 13, 2022 00:41
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants