Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: make mersenne internal #1444

Merged
merged 3 commits into from
Oct 14, 2022
Merged

refactor!: make mersenne internal #1444

merged 3 commits into from
Oct 14, 2022

Conversation

Shinigami92
Copy link
Member

closes #1348

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release labels Oct 13, 2022
@Shinigami92 Shinigami92 self-assigned this Oct 13, 2022
@Shinigami92 Shinigami92 linked an issue Oct 13, 2022 that may be closed by this pull request
Mark Mersenne module as internal and hide it from ts and the api-docs #1348
Closed
@codecov
Copy link

codecov bot commented Oct 13, 2022 •
edited
Loading

Codecov Report

Merging #1444 (56c7a95) into next (2c9622b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 56c7a95 differs from pull request most recent head 6a724a7. Consider uploading reports for the commit 6a724a7 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1444   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files        2166     2166           
  Lines      237450   237454    +4     
  Branches     1040     1040           
=======================================
+ Hits       236543   236547    +4     
  Misses        886      886           
  Partials       21       21
Impacted Files Coverage Δ
src/index.ts 100.00% <ø> (ø)
src/faker.ts 100.00% <100.00%> (ø)
src/internal/mersenne/mersenne.ts 100.00% <100.00%> (ø)
src/internal/mersenne/twister.ts 95.01% <100.00%> (ø)
src/modules/datatype/index.ts 96.29% <100.00%> (+0.04%) ⬆️

@Shinigami92 Shinigami92 marked this pull request as ready for review October 13, 2022 20:08
@Shinigami92 Shinigami92 requested a review from a team October 13, 2022 20:08
@Shinigami92 Shinigami92 requested a review from a team as a code owner October 13, 2022 20:08
@Shinigami92 Shinigami92 marked this pull request as draft October 14, 2022 17:24
@Shinigami92 Shinigami92 mentioned this pull request Oct 14, 2022
Merged
@Shinigami92 Shinigami92 marked this pull request as ready for review October 14, 2022 17:42
@Shinigami92
refactor!: make mersenne internal
66a6afd 
refactor!: move mersenne to internal dir + rewrite
ST-DDT
ST-DDT previously approved these changes Oct 14, 2022
View reviewed changes
@ST-DDT ST-DDT added the needs rebase There is a merge conflict label Oct 14, 2022
@Shinigami92
test: no need to filter MersenneModule anymore
c97b0d2 
refactor!: simplify mersenne functions

chore: add @internal tag

chore: cant use `@internal` types

chore: need to import type via relative

chore: revert changes to do them in separate PR
@Shinigami92 Shinigami92 force-pushed the 1348-mark-mersenne-module-as-internal-and-hide-it-from-ts-and-the-api-docs branch from 56c7a95 to c97b0d2 Compare October 14, 2022 19:38
@Shinigami92 Shinigami92 removed the needs rebase There is a merge conflict label Oct 14, 2022
@Shinigami92 Shinigami92 requested review from ST-DDT, ejcheng and a team October 14, 2022 19:39
@Shinigami92 Shinigami92 enabled auto-merge (squash) October 14, 2022 21:46
@Shinigami92 Shinigami92 merged commit 5aa747f into next Oct 14, 2022
@Shinigami92 Shinigami92 deleted the 1348-mark-mersenne-module-as-internal-and-hide-it-from-ts-and-the-api-docs branch October 14, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@ejcheng ejcheng ejcheng approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.

Mark Mersenne module as internal and hide it from ts and the api-docs
4 participants
@Shinigami92 @ST-DDT @ejcheng @xDivisionByZerox