refactor: reorganize apidoc scripts and reuse them for tests #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
p: 1-normal
ST-DDT
changed the title
ST-DDT
commented
Jan 19, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1759 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 2340 2340
Lines 242624 242624
Branches 1103 1103
=======================================
Hits 241772 241772
Misses 831 831
Partials 21 21 |
ST-DDT
commented
Jan 19, 2023
This was referenced Jan 19, 2023
Shinigami92
reviewed
Jan 20, 2023
Shinigami92
reviewed
Jan 20, 2023
Shinigami92
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
@ST-DDT reverted the additional change, so if we decide next team meeting if that was the correct way, we can do it in a separate PR ❤️ 👍
xDivisionByZerox
approved these changes
Jan 22, 2023
matthewmayer
pushed a commit
to matthewmayer/faker
that referenced
this pull request
Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The api doc scripts have grown over time and now multiple classes contain functions that import/user other files.
This PR reorganizes the methods into different files to keep the methods together.
I also added some new helper methods that simplify certain code parts and improve reuse-ability.