-
-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a warning on manual locale set #1812
add a warning on manual locale set #1812
Conversation
This is only applicable now. |
With #1735 we also add support for multiple fallback-locales, which IMO is a much needed feature. This also has an impact on #1441 . To simplify the migration for TS and JS users, we have the dummy/stub methods, that point to the new way (and in the future even to a chapter in the migration guide). If we schedule it to v9, then we delay the feature for roughly half a year. Please also read the v8 milestone descriptions (if you haven't already) to get a better idea of our planned roadmap. Could you please list some pros/cons so we have a better understanding of your idea/motivation for using the longer migration path? We would like to see the whole picture before deciding on this. If you have any questions feel free to ask them in Discord. One of our ideas for an explicit "deprecation" path is releasing a v7.7 that deprecates these methods, so it isn't just gone. |
You don't necessarily have to wait 6 months between releasing v8 and v9. I'm a firm believer that semver-major releases don't have to be particularly "major", its just that they flag up breaking changes. In fact too many breaking changes in a release can put people off upgrading. So basically I'm suggesting current v8.0 would be split into two,
|
If you don't want to do that, then a v7.7 containing just additional deprecation warnings to let people prepare for v8 is certainly better than nothing. |
Team Decision This proposal has been rejected. Will will write a migration guide and explicitly highlight this change. |
This is just a rough idea of how we could warn users who are setting locale at runtime but allow explicit import of a locale to work.