docs: Faker and utility pages #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: docs
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1940 +/- ##
==========================================
+ Coverage 99.61% 99.62% +0.01%
==========================================
Files 2561 2561
Lines 243239 243239
Branches 1274 1281 +7
==========================================
+ Hits 242301 242330 +29
+ Misses 913 884 -29
Partials 25 25 |
|
Should allLocales and allFakers be documented on these pages too? #1909 |
No, IMO they should be part of the localization page. |
|
I extracted the Faker jsdocs to its own PR #1960 to make reviewing them easier and let this PR focus on the infra/script side of things. |
ST-DDT
added
s: on hold
ST-DDT
force-pushed
the
docs/faker-and-utility-page
branch
from
120150c to
18b5cad
Compare
|
I activated a deploy preview for this PR: |
|
Tapping here goes to faker.html.html which 404s |
Shinigami92
approved these changes
Apr 2, 2023
|
@matthewmayer fixed |
matthewmayer
approved these changes
Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation pages for the
Fakerclass and standalone utility methods.Netlify-Preview: https://deploy-preview-2--serene-sprite-f3ef50.netlify.app/