Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(finance): simplify routingNumber implementation #1993

Merged
merged 2 commits into from
Mar 30, 2023
Merged

refactor(finance): simplify routingNumber implementation #1993

merged 2 commits into from
Mar 30, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 29, 2023 •
edited
Loading

Make the method more readable by using the string module directly to generate the prefix.

This PR is a precondition to deprecating helpers.replaceSymbolWithNumber.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: finance Something is referring to the finance module labels Mar 29, 2023
@ST-DDT ST-DDT requested review from a team March 29, 2023 19:14
@ST-DDT ST-DDT self-assigned this Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (next@3ae3691). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head a9a12a9 differs from pull request most recent head 911ecae. Consider uploading reports for the commit 911ecae to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1993   +/-   ##
=======================================
  Coverage        ?   99.62%           
=======================================
  Files           ?     2460           
  Lines           ?   240148           
  Branches        ?     1277           
=======================================
  Hits            ?   239244           
  Misses          ?      881           
  Partials        ?       23
Impacted Files Coverage Δ
src/modules/finance/index.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT mentioned this pull request Mar 29, 2023
Closed
@ST-DDT ST-DDT added the s: needs decision Needs team/maintainer decision label Mar 29, 2023
xDivisionByZerox
xDivisionByZerox approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused why no snapshot required any update, but I'm all here for it.

@ST-DDT ST-DDT removed the s: needs decision Needs team/maintainer decision label Mar 30, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) March 30, 2023 15:09
@ST-DDT ST-DDT merged commit b9d0fed into next Mar 30, 2023
@ST-DDT ST-DDT deleted the refactor/finance/simplify-routing-number branch March 30, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: finance Something is referring to the finance module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.
3 participants
@ST-DDT @Shinigami92 @xDivisionByZerox