Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(person): fix formatting issues #2005

Merged
merged 2 commits into from
Apr 2, 2023
Merged

docs(person): fix formatting issues #2005

merged 2 commits into from
Apr 2, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Apr 1, 2023

Fixes some jsdocs formatting issues in the PersonModule.

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Apr 1, 2023
@ST-DDT ST-DDT requested review from a team April 1, 2023 22:10
@ST-DDT ST-DDT self-assigned this Apr 1, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented Apr 1, 2023

@Shinigami92 Any idea why these aren't detected and fixed by prettier in CI?
I only found these by manually saving the file in VS Code.

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #2005 (361dded) into next (3c176b2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 361dded differs from pull request most recent head 624ac1c. Consider uploading reports for the commit 624ac1c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2005      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files        2560     2527      -33     
  Lines      243199   240723    -2476     
  Branches     1282     1275       -7     
==========================================
- Hits       242295   239814    -2481     
- Misses        879      884       +5     
  Partials       25       25              
Impacted Files Coverage Δ
src/modules/person/index.ts 96.85% <100.00%> (-0.01%) ⬇️

... and 37 files with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team April 2, 2023 07:50
@Shinigami92
Copy link
Member

@Shinigami92 Any idea why these aren't detected and fixed by prettier in CI? I only found these by manually saving the file in VS Code.

There could be multiple reasons right now
I have not checked the diff yet, but:

  • prettier had some updates recently
  • VSCode had an update (and so maybe the prettier VSCode extension might need an update)
  • pnpm had a major update (so the prettier plugin loading might have changed or couldn't get picked up)
  • and other tools like eslint and so on also had updates

so tldr, right now I feel like many tools have major upgrades around us
and maybe all these components need to be compatible again with each other

@ST-DDT ST-DDT enabled auto-merge (squash) April 2, 2023 11:49
@ST-DDT ST-DDT merged commit 9bf0a6d into next Apr 2, 2023
@ST-DDT ST-DDT deleted the docs/person/formatting branch April 2, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants