feat(location): es province should be county as its a 2nd level administrative area #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istrative area Allows it to be returned by fakerES.location.county() Currently it would only work via faker.helpers.fake https://en.wikipedia.org/wiki/Political_divisions_of_Spain https://en.wikipedia.org/wiki/Provinces_of_Spain
matthewmayer
added
p: 1-normal
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2156 +/- ##
=======================================
Coverage 99.59% 99.60%
=======================================
Files 2632 2632
Lines 245581 245581
Branches 1154 1155 +1
=======================================
+ Hits 244596 244601 +5
+ Misses 958 953 -5
Partials 27 27
|
ST-DDT
approved these changes
Jun 17, 2023
ejcheng
approved these changes
Jun 20, 2023
xDivisionByZerox
approved these changes
Jun 20, 2023
|
Should the explanation from the title ("as its a 2nd level administrative") move to the description? |
Yeah, we should keep the title to just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
es province should be county as its a 2nd level administrative area
Allows it to be returned by fakerES.location.county()
Currently it would only work via faker.helpers.fake
https://en.wikipedia.org/wiki/Political_divisions_of_Spain
https://en.wikipedia.org/wiki/Provinces_of_Spain