-
-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra(typescript-eslint): prefer-regexp-exec #2466
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
p: 1-normal
Nothing urgent
c: infra
Changes to our infrastructure or project setup
labels
Oct 10, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2466 +/- ##
=======================================
Coverage 99.58% 99.59%
=======================================
Files 2823 2823
Lines 255517 255517
Branches 1103 1105 +2
=======================================
+ Hits 254466 254474 +8
+ Misses 1023 1015 -8
Partials 28 28
|
xDivisionByZerox
approved these changes
Oct 10, 2023
This was referenced Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR for #2435. This applies the changes from #2108 to newer code and ensures future code abides to the same rules.
Enables the
@typescript-eslint/prefer-regexp-exec
lint rule.Reasoning:
Regexp.exec
behaves the same asstring.match(RegExp)
without/g
flag, with the main difference being that exec gurantees the index to be present:string.match(RegExp)
without/g
flag, also returns the index, but requires the not null assertion qualifier!
.