Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra(unicorn): prefer-code-point #2509

Merged
merged 5 commits into from
Nov 23, 2023
Merged

infra(unicorn): prefer-code-point #2509

merged 5 commits into from
Nov 23, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 27, 2023

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Oct 27, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 27, 2023
@ST-DDT ST-DDT self-assigned this Oct 27, 2023
@ST-DDT ST-DDT requested a review from a team as a code owner October 27, 2023 20:43
@ST-DDT ST-DDT mentioned this pull request Oct 27, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #2509 (e13b634) into next (aff0f80) will increase coverage by 0.00%.
The diff coverage is 88.88%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2509   +/-   ##
=======================================
  Coverage   99.56%   99.57%           
=======================================
  Files        2805     2805           
  Lines      250093   250097    +4     
  Branches     1095     1101    +6     
=======================================
+ Hits       249016   249035   +19     
+ Misses       1049     1034   -15     
  Partials       28       28
Files Coverage Δ
src/modules/finance/iban.ts 100.00% <100.00%> (ø)
src/modules/internet/index.ts 100.00% <100.00%> (ø)
src/modules/string/index.ts 100.00% <100.00%> (ø)
src/modules/helpers/index.ts 98.99% <81.81%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

xDivisionByZerox
xDivisionByZerox previously approved these changes Oct 31, 2023
View reviewed changes
src/modules/internet/index.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested review from a team and xDivisionByZerox November 2, 2023 17:23
@ST-DDT ST-DDT force-pushed the infra/unicorn/prefer-code-point branch from c77b927 to 7ac949c Compare November 7, 2023 23:05
@xDivisionByZerox xDivisionByZerox merged commit 9b00fe9 into next Nov 23, 2023
20 checks passed
@xDivisionByZerox xDivisionByZerox deleted the infra/unicorn/prefer-code-point branch November 23, 2023 19:03
@dagistan-tuncbilek dagistan-tuncbilek mentioned this pull request Jun 14, 2024
Open
This was referenced Sep 13, 2024
Open
Open
Merged
@sindhuhack sindhuhack mentioned this pull request Sep 24, 2024
Open
@jiisuominen jiisuominen mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
2 participants
@ST-DDT @xDivisionByZerox