Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove obsolete image.urlPlaceholder integration test #3392

Merged
merged 5 commits into from
Feb 9, 2025

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Feb 3, 2025

Removes the integration test for the image.urlPlaceholder function that no longer produces working links and thus fails our periodic integration tests.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test m: image Something is referring to the image module labels Feb 3, 2025
@ST-DDT ST-DDT added this to the v9.x milestone Feb 3, 2025
@ST-DDT ST-DDT requested review from a team February 3, 2025 15:54
@ST-DDT ST-DDT self-assigned this Feb 3, 2025
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 07500ba
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67a910321868b700089b30fc
😎 Deploy Preview https://deploy-preview-3392.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (9c42195) to head (07500ba).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3392   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2811     2811           
  Lines      216965   216965           
  Branches      941      940    -1     
=======================================
  Hits       216914   216914           
  Misses         51       51           

@ST-DDT ST-DDT enabled auto-merge (squash) February 9, 2025 20:30
@ST-DDT ST-DDT disabled auto-merge February 9, 2025 20:33
@ST-DDT ST-DDT merged commit 8053e5b into next Feb 9, 2025
23 checks passed
@ST-DDT ST-DDT deleted the chore/integration-test/image/placeholder-remove branch February 9, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: test m: image Something is referring to the image module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants