test: add parameter defaults to our signature generation test #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #793 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 1921 1921
Lines 177120 177120
Branches 909 909
=======================================
Hits 175967 175967
Misses 1097 1097
Partials 56 56 |
Shinigami92
approved these changes
Apr 7, 2022
pkuczynski
approved these changes
Apr 7, 2022
ST-DDT
added
p: 1-normal
ST-DDT
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #792 (comment) I noticed, that we currently don't test our parameter default generation/extraction for the api docs.
This PR fixes that.
I moved some code to utils in order to reuse them in the test to avoid differences between the two.