Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: log messages for unique fields #828

Merged
merged 3 commits into from
Apr 10, 2022
Merged

refactor: log messages for unique fields #828

merged 3 commits into from
Apr 10, 2022

Conversation

Shinigami92
Copy link
Member

This is a addendum to #810

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Apr 10, 2022
@Shinigami92 Shinigami92 added this to the v6.2 - New small features milestone Apr 10, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner April 10, 2022 14:29
@Shinigami92 Shinigami92 self-assigned this Apr 10, 2022
@codecov
Copy link

codecov bot commented Apr 10, 2022 •
edited
Loading

Codecov Report

Merging #828 (badef98) into main (d544ef9) will decrease coverage by 0.01%.
The diff coverage is 54.68%.

@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
- Coverage   99.35%   99.34%   -0.02%     
==========================================
  Files        1921     1921              
  Lines      179096   179157      +61     
  Branches      892      894       +2     
==========================================
+ Hits       177948   177980      +32     
- Misses       1092     1121      +29     
  Partials       56       56
Impacted Files Coverage Δ
src/unique.ts 78.03% <54.68%> (-21.97%) ⬇️

@Shinigami92 Shinigami92 requested a review from a team April 10, 2022 14:55
Shinigami92
Shinigami92 commented Apr 10, 2022
View reviewed changes
ST-DDT
ST-DDT approved these changes Apr 10, 2022
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need tests?

@Shinigami92 Shinigami92 requested review from a team April 10, 2022 15:29
@ST-DDT ST-DDT merged commit 301ad54 into main Apr 10, 2022
@ST-DDT ST-DDT deleted the refactor-unique-deprecate-fields branch April 10, 2022 15:44
pkuczynski
pkuczynski approved these changes Apr 10, 2022
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@pkuczynski pkuczynski pkuczynski approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent
Projects
None yet
Milestone
v6.2 - New small features
Development

Successfully merging this pull request may close these issues.
3 participants
@Shinigami92 @pkuczynski @ST-DDT