test: simplify seeded address tests #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: chore
Shinigami92
approved these changes
Apr 29, 2022
Codecov Report
@@ Coverage Diff @@
## main #889 +/- ##
=======================================
Coverage 99.41% 99.41%
=======================================
Files 1959 1959
Lines 210830 210830
Branches 901 901
=======================================
Hits 209600 209600
Misses 1172 1172
Partials 58 58 |
pkuczynski
approved these changes
Apr 29, 2022
xDivisionByZerox
added
the
m: location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a preparation PR for the test snapshots, that I will do in a separate PR once #875 is merged.
It simplifies most of address tests into a single for loop and checks the entire
streetAddressinstead of just the building number.