chore: generate consistent definition order for locales #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: chore
Shinigami92
changed the title
Codecov Report
@@ Coverage Diff @@
## main #965 +/- ##
==========================================
- Coverage 99.66% 99.66% -0.01%
==========================================
Files 1970 1970
Lines 210012 210012
Branches 887 886 -1
==========================================
- Hits 209312 209309 -3
- Misses 681 684 +3
Partials 19 19
|
Shinigami92
approved these changes
May 17, 2022
ejcheng
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
generate:localesscript to generate a consistent locale definition order in both windows and linux.Please test this on all your OSes to ensure this works consistently.