-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Would it be possible to tie quotes to characters? #1011
Comments
I made a Dune library in PR 1051 and took a swing at how we could implement your idea, which I like very much. If people like my approach the community would have to restructure their .yml files to take advantage, plus some grunt work will be needed to tag all the quotes with the corresponding character. |
Nice, I'll keep an eye on the PR and maybe I'll take a stab at it for Star Wars. |
Side note 1: Some variation of "I've got a bad feeling about this" is in every movie so I'm including every permutation to keep the running joke going. Side note 2: There is a division between characters and droids in the .yml. Might be fun to have a random droid quote versus random character quotes. Side note 3: I am sorely tempted to change the .yml file to something like this characters:
yoda:
alias: ['yoda', 'master yoda']
associations: ['jedi council', 'rebel alliance']
quotes: ["Do. Or do not. There is no try."] but that seems firmly in overkill territory. |
Closing this since #1054 has been merged |
ex.
The text was updated successfully, but these errors were encountered: