Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dune and Potential Solution to Issue 1011 #1051

Merged
merged 9 commits into from
Oct 23, 2017

Conversation

russellschmidt
Copy link
Contributor

@russellschmidt russellschmidt commented Oct 23, 2017

This provides a Dune module based on the best-selling Science Fiction novel/series of all time, Frank Herbert's Dune, with some choice quotes from the cult classic 'Dune' film by David Lynch.

More importantly, in Issue 1011 there was interest expressed in how we can randomly generate quotes by character as opposed to having quotes come out of one very large array of quotes undifferentiated by who said them. This is one solution, letting users either have a completely random quote or saying, or submit a character for quotes or source for a saying to pull a quote from a correct subset.

@stympy
Copy link
Contributor

stympy commented Oct 23, 2017

Thanks for this! Could you remove the space between the method name and the parentheses in the method definitions? Then I'll be happy to merge. :)

@russellschmidt
Copy link
Contributor Author

Removed the spaces 👍

@stympy stympy merged commit be8fc67 into faker-ruby:master Oct 23, 2017
@russellschmidt russellschmidt deleted the dune branch October 23, 2017 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants