Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIC Codes #355

Closed
creativereason opened this issue May 24, 2015 · 2 comments
Closed

SIC Codes #355

creativereason opened this issue May 24, 2015 · 2 comments
Labels
💡 Issue: Feature Request

Comments

@creativereason
Copy link

When you are classifying and referencing companies, sometimes you need a SIC Code.

I've made a fork for adding this method to company and happy to do a pull / merge if this would be helpful for others.

# Get a 4 digit SIC code
Faker::Company.sic_code #=> "0110"
@b264
Copy link
Contributor

b264 commented May 24, 2015

If you want to submit a PR we will review it.
https://github.com/factory-helper/factory-helper

@vbrazo
Copy link
Member

vbrazo commented May 13, 2018

@creativereason did you create a PR for this issue? Has it already been closed?

@bruno-b-martins bruno-b-martins mentioned this issue Feb 14, 2019
Merged
vbrazo pushed a commit that referenced this issue Feb 15, 2019
@bruno-b-martins @vbrazo
Add sic_code to company #355 (#1540)
b3cc465 
* Add sic_code to company

* Update documentation
@vbrazo vbrazo closed this as completed Feb 15, 2019
davidmorton0 pushed a commit to davidmorton0/faker that referenced this issue Jul 12, 2021
@bruno-b-martins @vbrazo
Add sic_code to company faker-ruby#355 (faker-ruby#1540)
98f6d20 
* Add sic_code to company

* Update documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@creativereason @vbrazo @b264