-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Faker::Auto features to Faker::Vehicle #1260
Merged
Merged
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e7c1647
add automotive data
haruska 3f15ec1
allow for area and subscriber codes in canadian phone numbers
haruska f4caf81
numberize phone number parts
haruska 23c7d45
improve auto data to always have correct makes and models pairs
haruska 65628b0
fix Faker::Auto specs
ivanovaleksey ed9e8df
fix Faker::Auto.model when called without make
ivanovaleksey 8a8bde7
use rand_in_range method
ivanovaleksey 429f314
Merge branch 'master' into automotive
mrstebo 5b52ae4
Added locales file for Auto data.
mrstebo e2a925d
Fixed issues in the Auto.model due to fetch not being able to fetch a…
mrstebo 1476b4b
Moved Faker::Auto features into Faker::Vehicle.
mrstebo afec11f
Updated documentation for Faker::Vehicle.
mrstebo ed548e4
Added missing tests.
mrstebo 4e582db
Fixed Rubocop offences.
mrstebo 171226d
Updated the assertion so it matches the minimum range that the year m…
mrstebo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1981
works but I think we should use2005
instead. What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that sounds much better. Considering the range for the
year
method starts with2005
😅