Add Faker::UniqueGenerator - exclude method #1307
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an "add_to_previous_results" method to
UniqueGenerator
, allowing to manually specify already used values, or excluded ones.On a Rails app, I had collisions in the tests with manually defined values and the ones created by faker. I guess there are other use cases where having this feature could be useful.
I think the test speaks for itself:
I can change the method name if it's not understandable.